
Be spoiling for a fight
Context Matters
The phrase may describe someone's general attitude, not just a momentary mood. 
Metaphoric Use
It doesn't always mean a literal fight, but can refer to any argument or conflict. 
Aggressive Tone
Often implies that the person is not just willing, but eager to argue. 